Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtph264: accept non-compliant single FU-A frames #649

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

thinkski
Copy link
Contributor

@thinkski thinkski commented Dec 4, 2024

Some IP cameras (e.g. CostarHD) have been observed to emit single fragment RTP FU-A packets, with start and end bit both set, for sufficiently small H.264 P-frames. Rather than emit an error, workaround such non-compliant frames.

@aler9
Copy link
Member

aler9 commented Dec 4, 2024

Hello, thanks for this patch. Change it in order to make the linter happy and it will be merged.

Some IP cameras (e.g. CostarHD) have been observed to emit single
fragment RTP FU-A packets, with start and end bit both set, for
sufficiently small H.264 P-frames. Rather than emit an error,
workaround such non-compliant frames.
@thinkski
Copy link
Contributor Author

thinkski commented Dec 4, 2024

@aler9 Done.

@aler9 aler9 merged commit 44aaa09 into bluenviron:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants